tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/Program.h:54-56
+for (Global *G : Globals) {
+ G->block()->invokeDtor();
+}
antondaubert wrote:
> Seems like this change generates a
>
> ```
> use-of-uninitialized-value lib/AST/Interp/
antondaubert added inline comments.
Comment at: clang/lib/AST/Interp/Program.h:54-56
+for (Global *G : Globals) {
+ G->block()->invokeDtor();
+}
Seems like this change generates a
```
use-of-uninitialized-value lib/AST/Interp/Descriptor.cpp:150:22 i
shafik added inline comments.
Comment at: clang/lib/AST/Interp/Descriptor.cpp:46
+
+ Ptr += sizeof(InitMap *);
for (unsigned I = 0, NE = D->getNumElems(); I < NE; ++I) {
aaron.ballman wrote:
> shafik wrote:
> > I believe `Ptr` is not longer valid b/c of `free
aaron.ballman added inline comments.
Comment at: clang/lib/AST/Interp/Descriptor.cpp:46
+
+ Ptr += sizeof(InitMap *);
for (unsigned I = 0, NE = D->getNumElems(); I < NE; ++I) {
shafik wrote:
> I believe `Ptr` is not longer valid b/c of `free(IM)` b/c what `Pt
shafik added inline comments.
Comment at: clang/lib/AST/Interp/Descriptor.cpp:46
+
+ Ptr += sizeof(InitMap *);
for (unsigned I = 0, NE = D->getNumElems(); I < NE; ++I) {
I believe `Ptr` is not longer valid b/c of `free(IM)` b/c what `Ptr` points to
has not b
This revision was automatically updated to reflect the committed changes.
Closed by commit rGee9bbfa5e6ac: [clang][Interp] Make sure we free() allocated
InitMaps (authored by tbaeder).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136826/new/
https:
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
The changes look correct to me, but you may want to wait a little bit before
landing to give the other reviewers a chance to look this over given that
there's no tests possible f
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
They get allocated when calling `initialize()` on a
