[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

This revision was automatically updated to reflect the committed changes. Closed by commit rGab1140874fc6: [clang] Instantiate NTTPs and template default arguments with sugar (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13656

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

mizvekov updated this revision to Diff 472020. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136564/new/ https://reviews.llvm.org/D136564 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaTemplate.cpp clang/lib/Sema/SemaTemplateDeducti

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

mizvekov added a comment. @rtrieu @hokein I just proposed a fix for this at https://reviews.llvm.org/D136977 At least for the repro posted above, this was a pre-existing bug with unexpanded packs appearing within sugar, which the present patch potentialized by preserving the type alias when in

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

hokein added a comment. In D136564#3890676 , @rtrieu wrote: > I noticed some build failures after your commit. I'm trying to get a > standalone reproducer. Here is the broken testcase: // -std=c++17 #include template using FixedTypeT = Ty

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

rtrieu added a comment. I noticed some build failures after your commit. I'm trying to get a standalone reproducer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136564/new/ https://reviews.llvm.org/D136564 __

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

mizvekov added a comment. In D136564#3884470 , @glandium wrote: > This broke building Firefox with: > > In file included from Unified_cpp_dom_canvas0.cpp:65: > /tmp/gecko/dom/canvas/ClientWebGLContext.cpp:355:19: error: call to deleted > function 'Id

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

glandium added a comment. This broke building Firefox with: In file included from Unified_cpp_dom_canvas0.cpp:65: /tmp/gecko/dom/canvas/ClientWebGLContext.cpp:355:19: error: call to deleted function 'IdByMethod' const auto id = IdByMethod(); ^~

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2560c1266993: [clang] Instantiate NTTPs and template default arguments with sugar (authored by mizvekov). Repository: rG LLVM Github Monorepo CHA

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This makes use of the changes introduced in D134604 , in order to instantiate non-type