jloser added inline comments.
Comment at: clang/lib/AST/ExprConstant.cpp:15908
- llvm::TimeTraceScope TimeScope("isIntegerConstantExpr", [&] {
-return Loc->printToString(Ctx.getSourceManager());
- });
+ ExprTimeTraceScope TimeScope(this, Ctx, "isIntegerConstantExpr");
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2bb50a55b0f5: [clang] Fix time profile in
"isIntegerConstantExpr" (authored by Izaron).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136549/new/
https://re
Izaron marked 2 inline comments as done.
Izaron added inline comments.
Comment at: clang/lib/AST/ExprConstant.cpp:15908
- llvm::TimeTraceScope TimeScope("isIntegerConstantExpr", [&] {
-return Loc->printToString(Ctx.getSourceManager());
- });
+ ExprTimeTraceScope TimeScop
dyung accepted this revision.
dyung added a comment.
I'm not really familiar with this code, so I'll leave others to review the
actual change, but I can confirm that when I built a compiler with this change
and ran it against the failing tests they all now pass. So in that regard, LGTM.
Reposi
jloser accepted this revision.
jloser added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for the fix.
I did leave an open question or two though, but it is non-blocking.
Comment at: clang/lib/AST/ExprConstant.cpp:15908
- llvm::TimeTraceScope Tim
Izaron created this revision.
Izaron added reviewers: dyung, aaron.ballman, jloser.
Herald added a project: All.
Izaron requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The time profiler in `Expr::isIntegerConstantExpr` used to
call `Loc->pr
