[PATCH] D136546: [clang][unittest] Resolve ClangSupportTest link time errors

jmciver added a comment. Thanks @Izaron for taking the time to review and commit on my behalf! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136546/new/ https://reviews.llvm.org/D136546 ___ cfe-commits m

[PATCH] D136546: [clang][unittest] Resolve ClangSupportTest link time errors

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5032d89e44a: [clang][unittest] Resolve ClangSupportTest link time errors (authored by jmciver, committed by Izaron). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D136546: [clang][unittest] Resolve ClangSupportTest link time errors

Izaron added a comment. LGTM! I'm sorry that you had to fix CMakeLists.txt. It really "worked on my machine", I was running these commands: cmake --build build --target ClangSupportTests # build and link the binary ./build/tools/clang/unittests/Support/ClangSupportTests # run the binary Re

[PATCH] D136546: [clang][unittest] Resolve ClangSupportTest link time errors

jmciver added a comment. Added GitHub issue 58553 , which provides the full error message and repeatability information. If this patch is accepted can someone please commit on my behalf? - User name: `John McIver` - User email: `john.mciver

[PATCH] D136546: [clang][unittest] Resolve ClangSupportTest link time errors

jmciver created this revision. Herald added a project: All. jmciver added reviewers: Izaron, Ericson2314, thieta, tstellar. jmciver published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Resolves undefined references to vtable for clang::ASTConsu