[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

OfekShilon added subscribers: kosarev, OfekShilon. OfekShilon added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2393 +particular object (so for example, it's never correct to call this function +passing the addresses of fields in the same struct, elements of th

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

This revision was automatically updated to reflect the committed changes. Closed by commit rG07ef7b1ff21e: [Builtins] Add __builtin_assume_separate_storage (authored by bruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/ https://review

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt updated this revision to Diff 507133. davidtgoldblatt added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/ https://reviews.llvm.org/D136515 Files: clang/docs/LanguageExtensions.rst clang/docs/Releas

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/docs/LanguageExtensions.rst:2393 +particular object (so for example, it's never correct to call this function +passing the addresses of fields in the sa

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2393 +particular object (so for example, it's never correct to call this function +passing the addresses of fields in the same struct, elements of the same array, +etc.). bruno w

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

bruno added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2393 +particular object (so for example, it's never correct to call this function +passing the addresses of fields in the same struct, elements of the same array, +etc.). Not necessarily a

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt updated this revision to Diff 501315. davidtgoldblatt added a comment. Use utils/update_cc_test_checks.py for the codegen test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/ https://reviews.llvm.org/D136515 Files: cla

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt added a comment. In addition to the release notes addition, I also added an entry in LanguageExtensions.rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/ https://reviews.llvm.org/D136515 __

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt updated this revision to Diff 501297. davidtgoldblatt added a comment. Per comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/ https://reviews.llvm.org/D136515 Files: clang/docs/LanguageExtensions.rst clang/docs

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt added a comment. Summarizing a brief offline discussion: I think it's probably fine to just get rid of the SemaChecking changes entirely; type-checking here is done by the generalized builtin-handling code. I'll do the change if there's no objection. Repository: rG LLVM Githu

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

bruno added a comment. Additionally, this likely deserves an entry in `./clang/docs/ReleaseNotes.rst`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/ https://reviews.llvm.org/D136515 ___ cfe-c

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

bruno requested changes to this revision. bruno added a comment. This revision now requires changes to proceed. Nice, thanks for adding the builtin layer. Comment at: clang/lib/Sema/SemaChecking.cpp:7808 +/// Handle __builtin_assume_separate_storage. For now this is a no-op, bu

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt updated this revision to Diff 481770. davidtgoldblatt added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/ https://reviews.llvm.org/D136515 Files: clang/include/clang/Basic/Builtins.def clang/includ

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt updated this revision to Diff 481481. davidtgoldblatt added a comment. Per review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/ https://reviews.llvm.org/D136515 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt updated this revision to Diff 478394. davidtgoldblatt added a comment. Fix out-of-date comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/ https://reviews.llvm.org/D136515 Files: clang/include/clang/Basic/Builtins.

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt created this revision. Herald added a project: All. davidtgoldblatt updated this revision to Diff 476281. davidtgoldblatt added a comment. davidtgoldblatt updated this revision to Diff 476283. davidtgoldblatt retitled this revision from "[builtins] add separate storage builtin supp