[PATCH] D136451: GH58368: Correct concept checking in a lambda defined in concept

erichkeane added a comment. Reapplied after revert: https://reviews.llvm.org/rGb876f6e2f28779211a829d7d4e841fe68885ae20 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136451/new/ https://reviews.llvm.org/D136451 ___

[PATCH] D136451: GH58368: Correct concept checking in a lambda defined in concept

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7c922607c5b: GH58368: Correct concept checking in a lambda defined in concept (authored by erichkeane). Herald added a project: clang. Changed prio

[PATCH] D136451: GH58368: Correct concept checking in a lambda defined in concept

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. It looks like precommit CI caught a failing test case that should be fixed before landing, but otherwise this LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136451/

[PATCH] D136451: GH58368: Correct concept checking in a lambda defined in concept

erichkeane updated this revision to Diff 469696. erichkeane added a comment. Woops, forgot to update my test! Do it so we can get tests to run. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136451/new/ https://reviews.llvm.org/D136451 Files: clang/include/clang/AST/ASTNodeTraverser.

[PATCH] D136451: GH58368: Correct concept checking in a lambda defined in concept

erichkeane added inline comments. Comment at: clang/include/clang/AST/DeclTemplate.h:3310 +// during constraint checking. +class ConceptSpecializationDecl final +: public Decl, aaron.ballman wrote: > Would it make sense to rename this to `ImplicitConceptSpeci

[PATCH] D136451: GH58368: Correct concept checking in a lambda defined in concept

erichkeane updated this revision to Diff 469693. erichkeane marked 4 inline comments as done. erichkeane added a comment. Changes as Aaron suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136451/new/ https://reviews.llvm.org/D136451 Files: clang/include/clang/AST/ASTNodeTrave

[PATCH] D136451: GH58368: Correct concept checking in a lambda defined in concept

aaron.ballman added a comment. Generally, this looks reasonable to me. I did spot a few things, but nothing major. Should this change come with a release note for the fix? Comment at: clang/include/clang/AST/DeclTemplate.h:3310 +// during constraint checking. +class ConceptSpe

[PATCH] D136451: GH58368: Correct concept checking in a lambda defined in concept

erichkeane created this revision. erichkeane added a reviewer: aaron.ballman. Herald added a subscriber: arphaman. Herald added a project: All. erichkeane requested review of this revision. As that bug reports, the problem here is that the lambda's 'context-decl' was not set to the concept, and th