[PATCH] D136385: Add support for MC/DC in LLVM Source-Based Code Coverage

alanphipps added a comment. Thank you for the comments thus-far. I have split this patch into three stacked patches and updated them according to comments found on this review: Clang Front-end: https://reviews.llvm.org/D138849 LLVM back-end/compiler-rt: https://reviews.llvm.org/D138846 llvm-cov

[PATCH] D136385: Add support for MC/DC in LLVM Source-Based Code Coverage

alanphipps added a comment. Thank you (both) for looking at it! I appreciate your time. In D136385#3891311 , @peter.smith wrote: > I suspect that this patch will need to get split up into smaller parts. While > it is very useful to see everything at on

[PATCH] D136385: Add support for MC/DC in LLVM Source-Based Code Coverage

peter.smith added a comment. I've got about as far as the clang changes. As I mentioned in Discourse I'm not familiar enough in this area to give good feedback on the implementation, most if not all my comments fall under the bike shedding category. Will need to leave the high-level feedback to

[PATCH] D136385: Add support for MC/DC in LLVM Source-Based Code Coverage

ellis added inline comments. Comment at: llvm/lib/ProfileData/InstrProfCorrelator.cpp:208 maybeSwap(CounterOffset), + maybeSwap(BitmaskOffset), maybeSwap(FunctionPtr), Since `BitmaskOffset` and `NumBitmaskBytes` are always zero, I would rather