[PATCH] D136354: [Driver] Enable nested configuration files

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f67dc8b7c22: [Driver] Enable nested configuration files (authored by sepavloff). Changed prior to commit: https://reviews.llvm.org/D136354?vs=475400&id=475685#toc Repository: rG LLVM Github Monorepo

[PATCH] D136354: [Driver] Enable nested configuration files

sepavloff added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136354/new/ https://reviews.llvm.org/D136354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D136354: [Driver] Enable nested configuration files

MaskRay accepted this revision. MaskRay added a comment. > To solve such problems, the option --config is allowed inside ... `--config=` Comment at: clang/docs/UsersManual.rst:989 +``linux.opts`` is searched for in the directory ``~/.llvm/os``. Another way to +include a file c

[PATCH] D136354: [Driver] Enable nested configuration files

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. LGTM (without testing, just eyeball review). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136354/new/ https://reviews.llvm.org/D136354 ___

[PATCH] D136354: [Driver] Enable nested configuration files

sepavloff updated this revision to Diff 475400. sepavloff added a comment. Missed changes in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136354/new/ https://reviews.llvm.org/D136354 Files: clang/docs/UsersManual.rst clang/include/clang

[PATCH] D136354: [Driver] Enable nested configuration files

sepavloff updated this revision to Diff 475349. sepavloff added a comment. Removed support of `--config file`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136354/new/ https://reviews.llvm.org/D136354 Files: clang/docs/UsersManual.rst clang/i

[PATCH] D136354: [Driver] Enable nested configuration files

MaskRay added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1215-1222 +} else if (ArgStr == "--config") { + if (I + 1 == E) +return createStringError(std::errc::invalid_argument, + "Option '--config' requires an arg

[PATCH] D136354: [Driver] Enable nested configuration files

mgorny added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1215-1222 +} else if (ArgStr == "--config") { + if (I + 1 == E) +return createStringError(std::errc::invalid_argument, + "Option '--config' requires an argu

[PATCH] D136354: [Driver] Enable nested configuration files

sepavloff added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136354/new/ https://reviews.llvm.org/D136354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D136354: [Driver] Enable nested configuration files

sepavloff updated this revision to Diff 474455. sepavloff added a comment. Rebase patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136354/new/ https://reviews.llvm.org/D136354 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/Diag

[PATCH] D136354: [Driver] Enable nested configuration files

mgorny added a comment. I like this more than the alternative solution. The code still has some complexity but the behavior is fairly logical and consistent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136354/new/ https://reviews.llvm.org/D13635

[PATCH] D136354: [Driver] Enable nested configuration files

sepavloff created this revision. sepavloff added reviewers: aaron.ballman, kadircet, MaskRay, mgorny. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. sepavloff requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commit