[PATCH] D136343: [Lex] Add compatibility with MSVC

2022-10-21 Thread Qfrost via Phabricator via cfe-commits
Qfrost911 added a comment. I understand you mean. I think I can try to solve this problem, if I have enough time. Thank you very much for your response. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136343/new/ https://reviews.llvm.org/D136343 _

[PATCH] D136343: [Lex] Add compatibility with MSVC

2022-10-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D136343#3873284 , @Qfrost911 wrote: > I understand you mean, but I can't get function name at macro expedition > stage. Correct! We have a `PredefinedExpr` AST node type (https://github.com/llvm/llvm-project/blob/main/

[PATCH] D136343: [Lex] Add compatibility with MSVC

2022-10-20 Thread Qfrost via Phabricator via cfe-commits
Qfrost911 added a comment. I understand you mean, but I can't get function name at macro expedition stage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136343/new/ https://reviews.llvm.org/D136343 ___ c

[PATCH] D136343: [Lex] Add compatibility with MSVC

2022-10-20 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Thank you for the patch! It looks like it's missing test coverage for the changes, can you add some to `clang/test/Preprocessor`? One question I have is: if we're going to support `__FUNCTION__`, shouldn't we also sup

[PATCH] D136343: [Lex] Add compatibility with MSVC

2022-10-20 Thread Qfrost via Phabricator via cfe-commits
Qfrost911 created this revision. Qfrost911 added a reviewer: shafik. Herald added a project: All. Qfrost911 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The code below is valid in MSVC, but it is not allowed in clang printf(__FUNCTION