sammccall added inline comments.
Comment at:
clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:27
+ Symbol(Decl &D) : Storage(&D) {}
+ Symbol(tooling::stdlib::Symbol S) : Storage(S) {}
+
Doh, I was skimming and missed that you removed
This revision was automatically updated to reflect the committed changes.
Closed by commit rGce286eccacd6: [IncludeCleaner] Add public API (authored by
kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136293/new/
https://reviews.llvm.org/D13
kadircet marked an inline comment as done.
kadircet added inline comments.
Comment at:
clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:14
+#include "llvm/ADT/STLFunctionalExtras.h"
+#include
+
kadircet wrote:
> sammccall wrote:
> > Th
kadircet updated this revision to Diff 470106.
kadircet marked an inline comment as done.
kadircet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136293/new/
https://reviews.llvm.org/D136293
Files:
clang-tools-
kadircet marked 2 inline comments as done.
kadircet added inline comments.
Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:67
+llvm::errs() << "returning stdlib\n";
+return CB(Loc, Symbol(*SS), toHeader(SS->headers()));
+ }
samm
kadircet marked 13 inline comments as done.
kadircet added inline comments.
Comment at:
clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:14
+#include "llvm/ADT/STLFunctionalExtras.h"
+#include
+
sammccall wrote:
> This is awful but: as
hokein accepted this revision.
hokein added inline comments.
Comment at:
clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:7
+//
+//===--===//
+
would be nice to have so
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks! Looks good, feel free to address/disregard design comments as you see
fit.
Comment at:
clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysi
kadircet created this revision.
kadircet added reviewers: hokein, sammccall.
Herald added a project: All.
kadircet requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Introduces walkUsed, a very simple version of the public API to e
