[PATCH] D136188: Update docs for -fuse-ctor-homing

2022-10-27 Thread Amy Huang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe8433a2b06d5: Update docs for -fuse-ctor-homing (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136188/new/ https://reviews.llvm.org/D1

[PATCH] D136188: Update docs for -fuse-ctor-homing

2022-10-27 Thread Amy Huang via Phabricator via cfe-commits
akhuang updated this revision to Diff 471240. akhuang added a comment. Add another debug info strategy to the description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136188/new/ https://reviews.llvm.org/D136188 Files: clang/docs/UsersManual.rs

[PATCH] D136188: Update docs for -fuse-ctor-homing

2022-10-18 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good to me with the addition of the forth homing strategy. In D136188#3866494 , @probinson wrote: > +jmorse who is closer to this topic than

[PATCH] D136188: Update docs for -fuse-ctor-homing

2022-10-18 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a subscriber: jmorse. probinson added a comment. +jmorse who is closer to this topic than I am. We've had a few complaints from licensees about ctor homing, and debug-info size in general is something of a sensitive topic. But if we can come to a place where `-fstandalone-debug

[PATCH] D136188: Update docs for -fuse-ctor-homing

2022-10-18 Thread Amy Huang via Phabricator via cfe-commits
akhuang updated this revision to Diff 468687. akhuang added a comment. Move ctor homing info to fstandalone-debug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136188/new/ https://reviews.llvm.org/D136188 Files: clang/docs/UsersManual.rst Ind

[PATCH] D136188: Update docs for -fuse-ctor-homing

2022-10-18 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a subscriber: probinson. dblaikie added a comment. (Speaking of which, might be worth pushing on the changes to remove the flags/support for opting out of ctor homing... I know @probinson had some concerns - but I really don't want to end up holding onto the tech debt of these va

[PATCH] D136188: Update docs for -fuse-ctor-homing

2022-10-18 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D136188#3866385 , @akhuang wrote: > Actually, maybe I should add some of this info to the -fstandalone-debug > section. Ah, sure, if you like. At some point I think I/someone should write a full ramble about DWARF type hom

[PATCH] D136188: Update docs for -fuse-ctor-homing

2022-10-18 Thread Amy Huang via Phabricator via cfe-commits
akhuang added a comment. Actually, maybe I should add some of this info to the -fstandalone-debug section. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136188/new/ https://reviews.llvm.org/D136188 ___

[PATCH] D136188: Update docs for -fuse-ctor-homing

2022-10-18 Thread Amy Huang via Phabricator via cfe-commits
akhuang updated this revision to Diff 468677. akhuang edited the summary of this revision. akhuang added a comment. Remove documentation paragraph. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136188/new/ https://reviews.llvm.org/D136188 Files:

[PATCH] D136188: Update docs for -fuse-ctor-homing

2022-10-18 Thread Amy Huang via Phabricator via cfe-commits
akhuang added a comment. In D136188#3866266 , @dblaikie wrote: > (not sure whether to discuss this here or on the bug) > > Should we remove the documentation? Part of the principles of "cc1" flags is > that their implementation details, not to be publicl

[PATCH] D136188: Update docs for -fuse-ctor-homing

2022-10-18 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. (not sure whether to discuss this here or on the bug) Should we remove the documentation? Part of the principles of "cc1" flags is that their implementation details, not to be publicly used and maybe not to be publicly documented either? Repository: rG LLVM Github

[PATCH] D136188: Update docs for -fuse-ctor-homing

2022-10-18 Thread Amy Huang via Phabricator via cfe-commits
akhuang created this revision. akhuang added a reviewer: rnk. Herald added a project: All. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update docs to reflect the fact that this flag is on by default now. Repository: rG LLVM