Re: [PATCH] D13618: [Extension] Optimizing const member objects.

2015-12-02 Thread Richard Smith via cfe-commits
rsmith added a subscriber: rsmith. Comment at: lib/CodeGen/CGDecl.cpp:933 @@ +932,3 @@ + ASTContext &Ctx = getContext(); + auto &OffsetsInfo = InvariantOffsets.FindAndConstruct(Record).second; + OffsetsType &Args = OffsetsInfo.Offsets; Instead of tracking a sep

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

2015-11-05 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 39467. http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/CodeGenModule.h test/CodeGenCXX/const-invariant.cpp Index: test/CodeGenCXX/const-invariant.cpp ==

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

2015-11-05 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 39466. http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/CodeGenModule.h test/CodeGenCXX/const-invariant.cpp Index: test/CodeGenCXX/const-invariant.cpp ==

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

2015-11-05 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 39465. http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/CodeGenModule.h test/CodeGenCXX/const-invariant.cpp Index: test/CodeGenCXX/const-invariant.cpp ==

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

2015-11-05 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 39464. http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h test/CodeGenCXX/const-invariant.cpp Index: test/CodeGenCXX/const-invariant.cpp === --- test

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

2015-11-05 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 39463. http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h test/CodeGenCXX/const-invariant.cpp Index: test/CodeGenCXX/const-invariant.cpp === --- test

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

2015-11-05 Thread Larisse Voufo via cfe-commits
lvoufo added a reviewer: majnemer. lvoufo updated this revision to Diff 39458. lvoufo added a comment. Reify computed invariant offsets, and while we're at it, cleanup InvariantArgs: move it out of CodeGenModule.h and remove Offsets member field since offsets are already in the start instruction

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

2015-11-05 Thread Larisse Voufo via cfe-commits
lvoufo removed a reviewer: majnemer. lvoufo updated this revision to Diff 39411. lvoufo added a comment. Remove commented out line -- Offsets not needed on invariant_end calls after all. http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGe

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

2015-10-09 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 37024. http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/CodeGenModule.h test/CodeGenCXX/const-invariant.cpp Index: test/CodeGenCXX/const-invariant.cpp ==

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

2015-10-09 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 37023. http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/CodeGenModule.h test/CodeGenCXX/const-invariant.cpp Index: test/CodeGenCXX/const-invariant.cpp ==

[PATCH] D13618: [Extension] Optimizing const member objects.

2015-10-09 Thread Larisse Voufo via cfe-commits
lvoufo created this revision. lvoufo added reviewers: dberlin, chandlerc, majnemer, nlewycky. lvoufo added a subscriber: cfe-commits. Continued from D13603... http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/CodeGenModule.h test/CodeG