[PATCH] D136040: [X86] Support PREFETCHI instructions

pengfei updated this revision to Diff 468463. pengfei added a comment. Rebased on D136145 and split RIP optimization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136040/new/ https://reviews.llvm.org/D136040 Fi

[PATCH] D136040: [X86] Support PREFETCHI instructions

pengfei added a comment. In D136040#3862551 , @uweigand wrote: > In D136040#3862386 , @pengfei wrote: > >> Sure, it is possible. But at least for now, there's no real target requires >> it. Checked with `grep -rw

[PATCH] D136040: [X86] Support PREFETCHI instructions

craig.topper added a comment. There are too many things in this patch. Please up MC layer changes from intrinsic/builtin changes. The RIP optimization probably also be separate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136040/new/ https://rev

[PATCH] D136040: [X86] Support PREFETCHI instructions

uweigand added a comment. In D136040#3862386 , @pengfei wrote: > Sure, it is possible. But at least for now, there's no real target requires > it. Checked with `grep -rwn 'llvm.prefetch.*i32 0\s*)' llvm/test/CodeGen/`. But that's just within the LLVM so

[PATCH] D136040: [X86] Support PREFETCHI instructions

pengfei added a comment. In D136040#3862265 , @uweigand wrote: > In D136040#3862225 , @pengfei wrote: > >> 3. Add semacheck for prefetch write to instruction cache; >> >> I think the affected ARM and SystemZ tests

[PATCH] D136040: [X86] Support PREFETCHI instructions

uweigand added a comment. In D136040#3862225 , @pengfei wrote: > 3. Add semacheck for prefetch write to instruction cache; > > I think the affected ARM and SystemZ tests are not valid before. Could > @t.p.northover and @uweigand help to have a look? Thi

[PATCH] D136040: [X86] Support PREFETCHI instructions

pengfei added inline comments. Comment at: clang/include/clang/Driver/Options.td:4651 def mno_popcnt : Flag<["-"], "mno-popcnt">, Group; +def mprefetchi : Flag<["-"], "mprefetchi">, Group; +def mno_prefetchi : Flag<["-"], "mno-prefetchi">, Group; LuoYuanke wrote

[PATCH] D136040: [X86] Support PREFETCHI instructions

pengfei updated this revision to Diff 468195. pengfei added subscribers: uweigand, t.p.northover. pengfei added a comment. 1. Address review comments; 2. Optimize prefetchit0/1 to prefetcht0/1 for non-rip address; 3. Add semacheck for prefetch write to instruction cache; 4. Fix a bug that set `rw`

[PATCH] D136040: [X86] Support PREFETCHI instructions

LuoYuanke added inline comments. Comment at: clang/include/clang/Driver/Options.td:4651 def mno_popcnt : Flag<["-"], "mno-popcnt">, Group; +def mprefetchi : Flag<["-"], "mprefetchi">, Group; +def mno_prefetchi : Flag<["-"], "mno-prefetchi">, Group; I notice in l

[PATCH] D136040: [X86] Support PREFETCHI instructions

pengfei updated this revision to Diff 468109. pengfei added a comment. Fix lit fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136040/new/ https://reviews.llvm.org/D136040 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Driver/Opti

[PATCH] D136040: [X86] Support PREFETCHI instructions

pengfei updated this revision to Diff 468080. pengfei added a comment. Fix lit fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136040/new/ https://reviews.llvm.org/D136040 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Driver/Opti

[PATCH] D136040: [X86] Support PREFETCHI instructions

pengfei created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. pengfei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. For more details about these instructions, please refer to the lates