Re: [PATCH] D13603: [Introduction] C++ Const object optimization in LLVM

2015-12-02 Thread Richard Smith via cfe-commits
rsmith added a subscriber: rsmith. rsmith added a comment. Your http://reviews.llvm.org/D14419 removes a lot of the code added here. Can you update this patch to not add that code? I'd prefer not to review the portion of this code that you're about to delete. Comment at: lib/C

Re: [PATCH] D13603: [Introduction] C++ Const object optimization in LLVM

2015-10-09 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 37005. lvoufo added a comment. All formatting changes should be done by now. http://reviews.llvm.org/D13603 Files: include/clang/AST/DeclCXX.h include/clang/AST/Type.h lib/AST/DeclCXX.cpp lib/AST/Type.cpp lib/CodeGen/CGDecl.cpp lib/CodeGen/CGDecl

Re: [PATCH] D13603: [Introduction] C++ Const object optimization in LLVM

2015-10-09 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 37004. lvoufo added a comment. Fix regression test formatting. http://reviews.llvm.org/D13603 Files: include/clang/AST/DeclCXX.h include/clang/AST/Type.h lib/AST/DeclCXX.cpp lib/AST/Type.cpp lib/CodeGen/CGDecl.cpp lib/CodeGen/CGDeclCXX.cpp lib/

Re: [PATCH] D13603: [Introduction] C++ Const object optimization in LLVM

2015-10-09 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 37003. lvoufo added a comment. Fix unit test formatting. http://reviews.llvm.org/D13603 Files: include/clang/AST/DeclCXX.h include/clang/AST/Type.h lib/AST/DeclCXX.cpp lib/AST/Type.cpp lib/CodeGen/CGDecl.cpp lib/CodeGen/CGDeclCXX.cpp lib/CodeGe

Re: [PATCH] D13603: [Introduction] C++ Const object optimization in LLVM

2015-10-09 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 36991. lvoufo added a comment. Clang-formatted. http://reviews.llvm.org/D13603 Files: include/clang/AST/DeclCXX.h include/clang/AST/Type.h lib/AST/DeclCXX.cpp lib/AST/Type.cpp lib/CodeGen/CGDecl.cpp lib/CodeGen/CGDeclCXX.cpp lib/CodeGen/CGExprA