[PATCH] D135978: [clang][dataflow][NFC] Fix reachability warning.

2022-10-14 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7da087974f94: [clang][dataflow][NFC] Fix reachability warning. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135978/new/ https://revi

[PATCH] D135978: [clang][dataflow][NFC] Fix reachability warning.

2022-10-14 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added a comment. In D135978#3859272 , @xazax.hun wrote: > I'd argue the warning is correct as you could store "non-enum" integer values > into an enum typed variable (and people do that fairly often with bitwise > enums). Good point. Feels wron

[PATCH] D135978: [clang][dataflow][NFC] Fix reachability warning.

2022-10-14 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. I'd argue the warning is correct as you could store "non-enum" integer values into an enum typed variable (and people do that fairly often with bitwis

[PATCH] D135978: [clang][dataflow][NFC] Fix reachability warning.

2022-10-14 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel created this revision. ymandel added a reviewer: gribozavr2. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Some compilers can't determine that all cases of t