[PATCH] D135953: [IncludeCleaner] Introduce decl to location mapping

This revision was automatically updated to reflect the committed changes. kadircet marked 6 inline comments as done. Closed by commit rGf82f5b0507a2: [include-cleaner] Introduce symbol to location mapping (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D135953?vs=47861

[PATCH] D135953: [IncludeCleaner] Introduce decl to location mapping

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/include-cleaner/lib/AnalysisInternal.h:29 #include "llvm/ADT/STLFunctionalExtras.h" +#include +#include unused? (

[PATCH] D135953: [IncludeCleaner] Introduce decl to location mapping

kadircet updated this revision to Diff 478611. kadircet marked 6 inline comments as done. kadircet added a comment. - Leaving out all the pieces around signals as discussed. - Update tests to use a LocateExample helper, have a test for macros. - Get rid of residues in other test files. Repositor

[PATCH] D135953: [IncludeCleaner] Introduce decl to location mapping

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/AnalysisInternal.h:87 +/// FIXME: Expose in public API for decision making (ranking, ignoring, etc.). +enum class Hint : uint8_t { + /// Declaration for the symbol, which is provided by all locati

[PATCH] D135953: [IncludeCleaner] Introduce decl to location mapping

kadircet updated this revision to Diff 476091. kadircet added a comment. - Rebase - Move to new file - Handle macros - Change from boolean output to enum for signalling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135953/new/ https://reviews.llvm.

[PATCH] D135953: [IncludeCleaner] Introduce decl to location mapping

kadircet added a comment. In D135953#3861180 , @tschuett wrote: > We support Apple Clang 9.3, but `std:variant` ships with Apple Clang 10.0. :-( Hi @tschuett, there are other pieces of LLVM that use `` today already, some big components include TableGen

[PATCH] D135953: [IncludeCleaner] Introduce decl to location mapping

tschuett added a comment. We support Apple Clang 9.3, but `std:variant` ships with Apple Clang 10.0. :-( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135953/new/ https://reviews.llvm.org/D135953 ___ cfe

[PATCH] D135953: [IncludeCleaner] Introduce decl to location mapping

tschuett added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/AnalysisInternal.h:64 +using SymbolLocation = std::variant; +/// A set of locations that provides the declaration, while indicating if sammccall wrote: > This is an important publ

[PATCH] D135953: [IncludeCleaner] Introduce decl to location mapping

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/AnalysisInternal.h:64 +using SymbolLocation = std::variant; +/// A set of locations that provides the declaration, while indicating if This is an important public API concept ==>

[PATCH] D135953: [IncludeCleaner] Introduce decl to location mapping

kadircet created this revision. kadircet added reviewers: hokein, sammccall. Herald added a subscriber: mgrang. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Creates a one to many mapping,