This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
li.zhe.hua marked an inline comment as done.
Closed by commit rG576283c3a8ef: [clang] Support `constexpr` for some
`ASTNodeKind` member functions (authored by li.zhe.hu
li.zhe.hua marked an inline comment as done.
li.zhe.hua added inline comments.
Comment at: clang/include/clang/AST/ASTTypeTraits.h:90-92
bool operator<(const ASTNodeKind &Other) const {
return KindId < Other.KindId;
}
aaron.ballman wrote:
> Any reason
li.zhe.hua updated this revision to Diff 467512.
li.zhe.hua added a comment.
Appease clang-format, add constexpr to operator<.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135816/new/
https://reviews.llvm.org/D135816
Files:
clang/include/clang/
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a minor question.
Comment at: clang/include/clang/AST/ASTTypeTraits.h:90-92
bool operator<(const ASTNodeKind &Other) const {
return Kind
shafik added a comment.
LGTM, looks mostly straight forward but I am not super familiar with this code
so I will let Aaron also review it too.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135816/new/
https://reviews.llvm.org/D135816
li.zhe.hua created this revision.
li.zhe.hua added a reviewer: aaron.ballman.
Herald added a project: All.
li.zhe.hua requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Add `constexpr` support for:
- The `getFromNodeKind` factory function
- `
