This revision was automatically updated to reflect the committed changes.
Closed by commit rG082593ff7aff: [HIP] Detect HIP for Debian/Fedora (authored
by yaxunl).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135796/ne
yaxunl updated this revision to Diff 467282.
yaxunl marked an inline comment as done.
yaxunl added a comment.
only check /usr and/usr/local for debian and redhat
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135796/new/
https://reviews.llvm.org/D135796
Files:
clang/lib/Driver/ToolCha
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:309
+ ROCmSearchDirs.emplace_back(D.SysRoot + "/usr/local",
+ /*StrictChecking=*/true);
tra wrote:
> yaxunl w
tra added inline comments.
Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:309
+ ROCmSearchDirs.emplace_back(D.SysRoot + "/usr/local",
+ /*StrictChecking=*/true);
yaxunl wrote:
> tra wrote:
> > Should it be done for Debian/Fedor
yaxunl added inline comments.
Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:309
+ ROCmSearchDirs.emplace_back(D.SysRoot + "/usr/local",
+ /*StrictChecking=*/true);
tra wrote:
> Should it be done for Debian/Fedora only? See
>
tra added inline comments.
Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:309
+ ROCmSearchDirs.emplace_back(D.SysRoot + "/usr/local",
+ /*StrictChecking=*/true);
Should it be done for Debian/Fedora only? See
clang/include/clan
yaxunl created this revision.
yaxunl added a reviewer: tra.
Herald added subscribers: kosarev, kerbowa, jvesely.
Herald added a project: All.
yaxunl requested review of this revision.
Herald added a subscriber: MaskRay.
HIP is installed at /usr or /usr/local on Debin/Fedora,
and the version file i
