This revision was automatically updated to reflect the committed changes.
Closed by commit rG8d72f445f799: [Clang] Do not crash when an invalid offload
architecture is set (authored by jhuber6).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135791/ne
jhuber6 updated this revision to Diff 467204.
jhuber6 added a comment.
Making suggested changes, Early exists is part of the LLVM style so it's
definitely better.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135791/new/
https://reviews.llvm.org/D
tra accepted this revision.
tra added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:4211
if (IsNVIDIAGpuArch(Arch))
-return Args.MakeArgStringRef(CudaArchToString(Arch));
+return StringRef(Args.MakeArgStringRef(CudaArchToString(Arch)));
Th
jhuber6 updated this revision to Diff 467199.
jhuber6 added a comment.
Making suggested changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135791/new/
https://reviews.llvm.org/D135791
Files:
clang/lib/Driver/Driver.cpp
clang/test/Driver/cu
jhuber6 added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:4191
/// or CUDA architecture.
-static StringRef getCanonicalArchString(Compilation &C,
-const llvm::opt::DerivedArgList &Args,
-
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM with few nits.
Comment at: clang/lib/Driver/Driver.cpp:4191
/// or CUDA architecture.
-static StringRef getCanonicalArchString(Compilation &C,
-
jhuber6 updated this revision to Diff 467188.
jhuber6 added a comment.
Fix missing `None` return on HIP.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135791/new/
https://reviews.llvm.org/D135791
Files:
clang/lib/Driver/Driver.cpp
clang/test/D
jhuber6 created this revision.
jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl.
Herald added a project: All.
jhuber6 requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.
If an invalid architecture is set we currently ret
