This revision was automatically updated to reflect the committed changes.
Closed by commit rGf6f02e090072: [clang][Interp] Implement for loops (authored
by tbaeder).
Changed prior to commit:
https://reviews.llvm.org/D135764?vs=467089&id=470727#toc
Repository:
rG LLVM Github Monorepo
CHANGES
tbaeder added inline comments.
Comment at: clang/test/AST/Interp/loops.cpp:271
+ /// be rejected.
+ constexpr int f6() {
+while(true);
aaron.ballman wrote:
> Another test to add here: `for (;;);` is just as infinite.
Heh, that's what this was supposed to
tbaeder marked an inline comment as done.
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:361
+ this->emitLabel(IncLabel);
+ if (Inc && !this->discard(Inc))
+return false;
aaron.ballman wrote:
> What does the call to `dis
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from some minor points.
Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:361
+ this->emitLabel(IncLabel);
+ if (Inc && !this->discard(Inc))
+
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135764/new/
https://reviews.llvm.org/D135764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://revi
