This revision was automatically updated to reflect the committed changes.
Closed by commit rG12c6a41f5249: [HIP] Fix unbundling archive (authored by
yaxunl).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135724/new/
ht
tra accepted this revision.
tra added a comment.
LGTM
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1839
auto Ext = IsMSVC ? ".lib" : ".a";
- if (!Lib.startswith(":") && llvm::sys::fs::exists(Lib)) {
-ArchiveOfBundles = Lib;
-FoundAOB = true;
+ if (!Lib.st
yaxunl added inline comments.
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1839
auto Ext = IsMSVC ? ".lib" : ".a";
- if (!Lib.startswith(":") && llvm::sys::fs::exists(Lib)) {
-ArchiveOfBundles = Lib;
-FoundAOB = true;
+ if (!Lib.startswith(":") && !Lib.star
tra added inline comments.
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1839
auto Ext = IsMSVC ? ".lib" : ".a";
- if (!Lib.startswith(":") && llvm::sys::fs::exists(Lib)) {
-ArchiveOfBundles = Lib;
-FoundAOB = true;
+ if (!Lib.startswith(":") && !Lib.startsw
saiislam accepted this revision.
saiislam added a comment.
This revision is now accepted and ready to land.
Thank you!
It is fixing our OpenMP smoke test failure.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135724/new/
https://reviews.llvm.org/D135724
yaxunl created this revision.
yaxunl added reviewers: tra, saiislam.
Herald added a project: All.
yaxunl requested review of this revision.
Herald added a subscriber: MaskRay.
When `-lxxx` is specified, if there happens to have a directory or
file with name `xxx`, clang will not look up `libxxx.a`
