This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4ba360d499f6: [CMake] Fix FindGRPC cmake module to allow
different layering (authored by steven_wu).
Repository:
rG LLVM Github Monorepo
CHANGES
sammccall accepted this revision.
sammccall added a comment.
Thanks, LG!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135712/new/
https://reviews.llvm.org/D135712
___
cfe-commits mailing list
cfe-commit
steven_wu updated this revision to Diff 467247.
steven_wu added a comment.
Turn generate_proto_sources back to function and forward argument more
elegantly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135712/new/
https://reviews.llvm.org/D135712
steven_wu added inline comments.
Comment at: cmake/Modules/FindGRPC.cmake:111
# They may be relative to the source dir or absolute (for generated protos).
-function(generate_protos LibraryName ProtoFile)
+macro(generate_protos_source GeneratedSource ProtoFile)
cmake_parse_arg
sammccall added inline comments.
Comment at: cmake/Modules/FindGRPC.cmake:111
# They may be relative to the source dir or absolute (for generated protos).
-function(generate_protos LibraryName ProtoFile)
+macro(generate_protos_source GeneratedSource ProtoFile)
cmake_parse_arg
steven_wu updated this revision to Diff 467243.
steven_wu added a comment.
Minor rename
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135712/new/
https://reviews.llvm.org/D135712
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra
steven_wu added inline comments.
Comment at: cmake/Modules/FindGRPC.cmake:111
# They may be relative to the source dir or absolute (for generated protos).
-function(generate_protos LibraryName ProtoFile)
+macro(generate_protos_source GeneratedSource ProtoFile)
cmake_parse_arg
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
thanks!
Comment at: cmake/Modules/FindGRPC.cmake:111
# They may be relative to the source dir or absolute (for generated protos).
-function(generate_protos LibraryName
steven_wu updated this revision to Diff 467217.
steven_wu added a comment.
Was missing the latest feedback. Bump FindGRPC module to top layer.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135712/new/
https://reviews.llvm.org/D135712
Files:
clan
steven_wu updated this revision to Diff 467215.
steven_wu added a comment.
Herald added a subscriber: bmahjour.
Herald added a project: clang.
Address review feedback
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135712/new/
https://reviews.llvm.or
sammccall added a comment.
Hmm, as mentioned on the bug, I think wrapping the deps and generated sources
into a library is an important part of what the build rule does.
If we need to split it up like this, I think a `generate_clang_protos` wrapper
in FindGRPC.cmake might be the right place to
steven_wu created this revision.
steven_wu added reviewers: sammccall, akyrtzi, rymiel.
Herald added subscribers: ributzka, kadircet, arphaman.
Herald added a project: All.
steven_wu requested review of this revision.
Herald added projects: LLVM, clang-tools-extra.
Herald added a subscriber: cfe-co
12 matches
Mail list logo
