aaron.ballman closed this revision.
aaron.ballman added a comment.
Thank you for the fast turn-around! I've commit in r249727.
~Aaron
http://reviews.llvm.org/D13567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
aaron.ballman updated this revision to Diff 36890.
aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
Corrected a simple copy-paste error.
http://reviews.llvm.org/D13567
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/CMakeLists.txt
clang-tidy/cert/Se
On Thu, Oct 8, 2015 at 3:47 PM, Samuel Benzaquen wrote:
> sbenza added inline comments.
>
>
> Comment at: clang-tidy/cert/SetLongJmpCheck.cpp:31
> @@ +30,3 @@
> +public:
> + explicit SetJmpMacroCallbacks(Preprocessor *PP, SetLongJmpCheck &Check)
> + : PP(PP), Check(Check) {}
sbenza added inline comments.
Comment at: clang-tidy/cert/SetLongJmpCheck.cpp:31
@@ +30,3 @@
+public:
+ explicit SetJmpMacroCallbacks(Preprocessor *PP, SetLongJmpCheck &Check)
+ : PP(PP), Check(Check) {}
Why do you pass one as a pointer and one as a referenc
aaron.ballman created this revision.
aaron.ballman added reviewers: alexfh, sbenza.
aaron.ballman added a subscriber: cfe-commits.
setjmp and longjmp facilities in C++ are unsafe due to the likelihood of
triggering undefined behavior with nontrivial type destruction, etc. Instead,
exception hand
