Trass3r updated this revision to Diff 488959.
Trass3r added a comment.
I can only refer to my last comment, even in latest trunk that code is still
active for the codegen passes.
But meanwhile I found the corresponding new code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
lebedev.ri resigned from this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: StephenFan.
This review may be stuck/dead, consider abandoning if no longer relevant.
Removing myself as reviewer in attempt to clean dashboard.
Reposit
Trass3r added a comment.
Well last time I checked it this code was still in use. When is it going to be
deleted?
Also the test has value to ensure the new pass manager emits these entries as
before.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D13
lebedev.ri requested changes to this revision.
lebedev.ri added a comment.
This revision now requires changes to proceed.
Old pass manager is dead. There is no point in making improvements to it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135658/
jamieschmeiser accepted this revision.
jamieschmeiser added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135658/new/
https://reviews.llvm.org/D135658
___
Trass3r added a comment.
Yeah it was conscious at least. No strong opinion on that though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135658/new/
https://reviews.llvm.org/D135658
___
cfe-commits maili
jamieschmeiser added a comment.
Is the mode change on check-time-trace-sections.py intended? I did a count of
python files under llvm-project and < 10% are 755. I'm not saying it is better
one way or the other; I'm just ensuring it is intentional.
Repository:
rG LLVM Github Monorepo
CHANG
Trass3r added a comment.
@thakis ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135658/new/
https://reviews.llvm.org/D135658
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm
Trass3r updated this revision to Diff 466946.
Trass3r added a comment.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
add test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135658/new/
https://reviews.llvm.org/D135658
Files
