[PATCH] D135583: [LLVM] Use DWARFv4 bitfields when tuning for GDB

2022-10-27 Thread David Spickett via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc6e2de60423a: [LLVM] Use DWARFv4 bitfields when tuning for GDB (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D135583: [LLVM] Use DWARFv4 bitfields when tuning for GDB

2022-10-27 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 471065. DavidSpickett added a comment. - DWARFvN -> DWARF vN - Remove superfluous brackets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135583/new/ https://reviews.llvm.org/D135583 Files: clang/docs/

[PATCH] D135583: [LLVM] Use DWARFv4 bitfields when tuning for GDB

2022-10-26 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:619 +Previously when emitting DWARFv4 and tuning for GDB, Clang would use DWARFv2's +``DW_AT_bit_offset`` and ``DW_AT_data_member_location``. Clang now uses DWARFv4's "DWARF v4" is more com

[PATCH] D135583: [LLVM] Use DWARFv4 bitfields when tuning for GDB

2022-10-26 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135583/new/ https://reviews.llvm.org/D135583 ___

[PATCH] D135583: [LLVM] Use DWARFv4 bitfields when tuning for GDB

2022-10-26 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 470766. DavidSpickett added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Test that linux DWARFv4 uses data_bit_offset and that adding GDB tuning does not change that. - Add release notes for clang and llvm. Repos