This revision was automatically updated to reflect the committed changes.
Closed by commit rGc585a44651f4: [Clang] Use C++17 in
constant-builtins-fmax.cpp test (authored by Izaron).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135486/new/
https://r
dyung added a comment.
Thanks, this is necessary because the Playstation platforms default to C++14,
not C++17.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135486/new/
https://reviews.llvm.org/D135486
___
Izaron added a comment.
Thanks, will land the patch after `Build 288902: pre-merge checks` is passed =)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135486/new/
https://reviews.llvm.org/D135486
___
cfe-
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
Looks fine
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135486/new/
https://reviews.llvm.org/D135486
_
Izaron added a comment.
ASAP fix from previous review request, see comment:
https://reviews.llvm.org/D134369#3843824
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135486/new/
https://reviews.llvm.org/D135486
__
Izaron created this revision.
Izaron added reviewers: efriedma, jcranmer-intel, aaron.ballman, cor3ntin.
Herald added a project: All.
Izaron requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Add `-std=c++17` to the test so that buildbot won't