This revision was automatically updated to reflect the committed changes.
Closed by commit rL250017: [ATTR] Automatic line feed after pragma-like
attribute. (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D13546?vs=36924&id=37080#toc
Repository:
rL LLVM
http://review
aaron.ballman added a comment.
Looks great, thank you!
~Aaron
http://reviews.llvm.org/D13546
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev updated this revision to Diff 36924.
ABataev marked 2 inline comments as done.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D13546
Files:
include/clang/Basic/Attr.td
lib/AST/DeclPrinter.cpp
test/Misc/ast-print-pragmas.cpp
utils/TableGen/ClangAttrEmitter.c
ABataev marked 2 inline comments as done.
Comment at: lib/AST/DeclPrinter.cpp:197
@@ -196,3 +196,3 @@
-void DeclPrinter::prettyPrintAttributes(Decl *D) {
+void DeclPrinter::prettyPrintAttributes(Decl *D, bool PrintPragmas) {
if (Policy.PolishForDeclaration)
a
aaron.ballman added a comment.
Wow, good catch on the fact that this didn't work at all! Thank you for
tackling it.
Comment at: lib/AST/DeclPrinter.cpp:197
@@ -196,3 +196,3 @@
-void DeclPrinter::prettyPrintAttributes(Decl *D) {
+void DeclPrinter::prettyPrintAttributes(Decl *D
ABataev retitled this revision from "[ATTR] Automatic line feed after
pragma-like attribute, NFC." to "[ATTR] Automatic line feed after pragma-like
attribute.".
ABataev updated this revision to Diff 36850.
ABataev added a comment.
Printing of pragma-like attributes for declarations did not worke
Ok, will do
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
08.10.2015 16:02, Aaron Ballman пишет:
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thanks! If you would be so kind as to a
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thanks! If you would be so kind as to add a test for #pragma
init_seg("bss"), that would be great -- it seems its printPrettyPragma never
put a newline in there for that at
ABataev created this revision.
ABataev added a reviewer: aaron.ballman.
ABataev added a subscriber: cfe-commits.
Automatically insert line feed after pretty printing of all pragma-like
attributes.
http://reviews.llvm.org/D13546
Files:
include/clang/Basic/Attr.td
utils/TableGen/ClangAttrEmit
