[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

thakis added a comment. This breaks tests on windows: http://45.33.8.238/win/67644/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135389/new/ https://reviews.llvm.org/D135

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG5aba68960719: [Clang] Emit a warning for ambiguous joined '-o' arguments (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135389/new/ ht

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 updated this revision to Diff 465894. jhuber6 added a comment. Using the implicit check suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135389/new/ https://reviews.llvm.org/D135389 Files: clang/include/clang/Basic/DiagnosticDri

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/test/Driver/unknown-arg.c:74 + +// RUN: %clang -### --offload-arch=sm_70 -o ffload-device-only -Werror=unknown-argument %s jhuber6 wrote: > tra wrote: > > jhuber6 wrote: > > > tra w

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 added inline comments. Comment at: clang/test/Driver/unknown-arg.c:74 + +// RUN: %clang -### --offload-arch=sm_70 -o ffload-device-only -Werror=unknown-argument %s tra wrote: > jhuber6 wrote: > > tra wrote: > > > Has this patch been updated with incomple

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

tra accepted this revision. tra added inline comments. Comment at: clang/test/Driver/unknown-arg.c:74 + +// RUN: %clang -### --offload-arch=sm_70 -o ffload-device-only -Werror=unknown-argument %s jhuber6 wrote: > tra wrote: > > Has this patch been updated with i

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 updated this revision to Diff 465883. jhuber6 added a comment. Apparently `-###` prevents `clang` from returning a non-zero error code. Fixing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135389/new/ https://reviews.llvm.org/D135389 File

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 added inline comments. Comment at: clang/test/Driver/unknown-arg.c:74 + +// RUN: %clang -### --offload-arch=sm_70 -o ffload-device-only -Werror=unknown-argument %s tra wrote: > Has this patch been updated with incomplete changes? This RUN line seems to

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

tra added inline comments. Comment at: clang/test/Driver/unknown-arg.c:74 + +// RUN: %clang -### --offload-arch=sm_70 -o ffload-device-only -Werror=unknown-argument %s Has this patch been updated with incomplete changes? This RUN line seems to miss `2>&1 | File

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 updated this revision to Diff 465876. jhuber6 marked an inline comment as done. jhuber6 added a comment. Changing test to just check that we emit to warnings in a separate run line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135389/new/

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Test nit. LGTM otherwise. Comment at: clang/test/Driver/unknown-arg.c:73 +// O-WARN-NEXT: warning: joined argument treated as '-o utput'; did you mean '--output'? +// O-WARN-NOT:

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 marked 2 inline comments as done. jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:337 +std::string Nearest; +if (getOpts().findNearest("-" + ArgString, Nearest, IncludedFlagsBitmask, + ExcludedFlagsBitmask) == 1)

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 updated this revision to Diff 465862. jhuber6 added a comment. Adjusting check to ensure that this only applies for an edit length of zero once the `-` is added. Also adding a negative check line for other inputs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

tra added a comment. LGTM in principle. Comment at: clang/lib/Driver/Driver.cpp:337 +std::string Nearest; +if (getOpts().findNearest("-" + ArgString, Nearest, IncludedFlagsBitmask, + ExcludedFlagsBitmask) == 1) This looks fo

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, jyknight, MaskRay, yaxunl, aaron.ballman, ronlieb. Herald added a subscriber: StephenFan. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a s