This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGadab08ecf2bd: [clang][Sema] Fix crash on invalid base
destructor (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST A
kadircet updated this revision to Diff 465365.
kadircet marked 2 inline comments as done.
kadircet added a comment.
-address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135254/new/
https://reviews.llvm.org/D135254
Files:
clang/lib/Sem
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
looks good, Sema::LookupDefaultConstructor already does the similar thing as
well.
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5699
CXXDestructorDecl *Dtor = LookupDestr
kadircet created this revision.
kadircet added a reviewer: hokein.
Herald added a project: All.
kadircet requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
LookupSpecialMember might fail, so changes the cast to cast_or_null.
Inside Sema, skip
