[PATCH] D135231: [clangd] Don't clone SymbolSlab::Builder arenas when finalizing.

2022-10-05 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6ea83fc98fd1: [clangd] Don't clone SymbolSlab::Builder arenas when finalizing. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135231/

[PATCH] D135231: [clangd] Don't clone SymbolSlab::Builder arenas when finalizing.

2022-10-04 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. My first take on this was to keep track in various ways of whether GC was required (statically known at callsite, or have builder track whether symbols were overwritten). However these failed to identify a bunch of cases where the arena wasn't shrinking, and this seem

[PATCH] D135231: [clangd] Don't clone SymbolSlab::Builder arenas when finalizing.

2022-10-04 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: adamcz. Herald added subscribers: kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Sym