[PATCH] D135199: [OpenMP][C++] Allow #pragma omp simd in constexpr functions

2022-10-07 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8274-8279 // Only if a local variable was declared in the function currently being // evaluated, do we expect to be able to find its value in the current // frame. (Otherwise it was likely

[PATCH] D135199: [OpenMP][C++] Allow #pragma omp simd in constexpr functions

2022-10-07 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8274-8279 // Only if a local variable was declared in the function currently being // evaluated, do we expect to be able to find its value in the current // frame. (Otherwise it was lik

[PATCH] D135199: [OpenMP][C++] Allow #pragma omp simd in constexpr functions

2022-10-05 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8274-8279 // Only if a local variable was declared in the function currently being // evaluated, do we expect to be able to find its value in the current // frame. (Otherwise it was likely

[PATCH] D135199: [OpenMP][C++] Allow #pragma omp simd in constexpr functions

2022-10-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added reviewers: shafik, erichkeane, tbaeder. aaron.ballman added a comment. Adding a few more reviewers who have been poking around in constant expression evaluation lately. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2722-2723 InGroup, Defau

[PATCH] D135199: [OpenMP][C++] Allow #pragma omp simd in constexpr functions

2022-10-04 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert created this revision. jdoerfert added reviewers: aaron.ballman, faisalv. Herald added subscribers: guansong, bollu, yaxunl. Herald added a project: All. jdoerfert requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. There is no reason (o