[PATCH] D135171: FreeBSD: enable __float128 on x86 and powerpc64le

arichardson added a comment. In D135171#4657080 , @brad wrote: > You can close this. The submitted patch https://github.com/llvm/llvm-project/commit/23c47eba879769a29772c999be2991201c2fe399 was not the same since it omitted ppc64. So I guess this shoul

[PATCH] D135171: FreeBSD: enable __float128 on x86 and powerpc64le

brad added a comment. You can close this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135171/new/ https://reviews.llvm.org/D135171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D135171: FreeBSD: enable __float128 on x86 and powerpc64le

emaste added a comment. Looks like this still needs someone to push it -- @brooks if you rebase and send to GitHub I cna pick it up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135171/new/ https://reviews.llvm.org/D135171 ___

[PATCH] D135171: FreeBSD: enable __float128 on x86 and powerpc64le

nemanjai accepted this revision. nemanjai added a comment. My comments are minor nits that don't require another review, so LGTM. Comment at: clang/lib/Basic/Targets/OSTargets.h:245-250 switch (Triple.getArch()) { -default: +case llvm::Triple::ppc64le: case ll

[PATCH] D135171: FreeBSD: enable __float128 on x86 and powerpc64le

dim accepted this revision. dim added a comment. LGTM again :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135171/new/ https://reviews.llvm.org/D135171 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D135171: FreeBSD: enable __float128 on x86

brooks updated this revision to Diff 509934. brooks added a comment. - Rebase - Add powerpc64le Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135171/new/ https://reviews.llvm.org/D135171 Files: clang/lib/Basic/Targets/OSTargets.h clang/test/Co

[PATCH] D135171: FreeBSD: enable __float128 on x86

pkubaj requested changes to this revision. pkubaj added a comment. This revision now requires changes to proceed. Could you modify it appropriately to also enable ppc, ppc64 and ppc64le? I checked whether it works on FreeBSD 13.1-RELEASE and it builds and works fine. Repository: rG LLVM Githu

[PATCH] D135171: FreeBSD: enable __float128 on x86

brooks added a comment. @arichardson please commit. I do not have commit access. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135171/new/ https://reviews.llvm.org/D135171 ___ cfe-commits mailing

[PATCH] D135171: FreeBSD: enable __float128 on x86

arichardson added a comment. @brooks do you want me to commit this for you or do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135171/new/ https://reviews.llvm.org/D135171 ___ cfe

[PATCH] D135171: FreeBSD: enable __float128 on x86

brooks updated this revision to Diff 465223. brooks added a comment. Add a test as requested by @arichardson Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135171/new/ https://reviews.llvm.org/D135171 Files: clang/lib/Basic/Targets/OSTargets.h

[PATCH] D135171: FreeBSD: enable __float128 on x86

emaste accepted this revision. emaste added a comment. OK. I think the switch will become unwieldy if additional arch-dependent things are added but could be dealt with then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135171/new/ https://review

[PATCH] D135171: FreeBSD: enable __float128 on x86

arichardson accepted this revision. arichardson added a comment. Could you add a RUN: line to `clang/test/CodeGenCXX/float128-declarations.cpp? Code LGTM. // RUN: %clang_cc1 -no-opaque-pointers -emit-llvm -triple x86_64-unknown-freebsd -std=c++11 \ // RUN: %s -o - | FileCheck %s -check-pr

[PATCH] D135171: FreeBSD: enable __float128 on x86

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135171/new/ https://reviews.llvm.org/D135171 ___ cfe-c

[PATCH] D135171: FreeBSD: enable __float128 on x86

brooks created this revision. brooks added reviewers: arichardson, emaste, dim. Herald added a subscriber: krytarowski. Herald added a project: All. brooks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a prerequisite for proper ru