This revision was automatically updated to reflect the committed changes.
Closed by commit rG6194229c6287: [analyzer] Make directly bounded
LazyCompoundVal as lazily copied (authored by tomasz-kaminski-sonarsource).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://review
steakhal marked 5 inline comments as done.
steakhal added a comment.
Thanks for the review @martong!
I'll land this tomorrow.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135136/new/
https://reviews.llvm.org/D135136
__
martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:2843
-// subregions of the `LCS.getRegion()` also lazily copied.
-if (const MemRegion *R = LCS->getRe
tomasz-kaminski-sonarsource added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:2843
-// subregions of the `LCS.getRegion()` also lazily copied.
-if (const MemRegion *R = LCS->getRegion())
- SymReaper.markLazilyCopied(R);
martong added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:2290
List.insert(List.end(), InnerList.begin(), InnerList.end());
- continue;
}
steakhal wrote:
> Here is the `continue` which previously prevented `getInter
steakhal added a comment.
Ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135136/new/
https://reviews.llvm.org/D135136
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
steakhal updated this revision to Diff 464961.
steakhal added a comment.
rebased
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135136/new/
https://reviews.llvm.org/D135136
Files:
clang/lib/StaticAnalyzer/Core/RegionStore.cpp
clang/test/Analysi
steakhal added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:2290
List.insert(List.end(), InnerList.begin(), InnerList.end());
- continue;
}
Here is the `continue` which previously prevented `getInterestingValues()`
steakhal created this revision.
steakhal added reviewers: NoQ, martong, xazax.hun.
Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus,
mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware.
Herald added a reviewer: Szelethus.
Herald added a project: All.
steak
