[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

jansvoboda11 added a comment. In D135128#4108588 , @stella.stamenova wrote: > In D135128#4107816 , @jansvoboda11 > wrote: > >> @stella.stamenova ping > > Thanks for the reminder! > > I spent some time looking fo

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

stella.stamenova added a comment. In D135128#4107816 , @jansvoboda11 wrote: > @stella.stamenova ping Thanks for the reminder! I spent some time looking for a combination of VS + Win 10 SDK that would work with the new flag, and I believe I've found (a

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

jansvoboda11 added a comment. @stella.stamenova ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135128/new/ https://reviews.llvm.org/D135128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

jansvoboda11 added a comment. In D135128#3926404 , @stella.stamenova wrote: > In D135128#3921902 , @jansvoboda11 > wrote: > >> @stella.stamenova Any updates? > > We haven't had time to come up with a proper solu

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

stella.stamenova added a comment. In D135128#3921902 , @jansvoboda11 wrote: > @stella.stamenova Any updates? We haven't had time to come up with a proper solution yet. One short-term solution (assuming there's urgency in making the change) would be to

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

jansvoboda11 added a comment. @stella.stamenova Any updates? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135128/new/ https://reviews.llvm.org/D135128 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

jansvoboda11 added a comment. Thanks, that sounds good. Reverting shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135128/new/ https://reviews.llvm.org/D135128 ___ cfe-commits mailing list cfe-comm

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

stella.stamenova added a comment. In D135128#3902772 , @jansvoboda11 wrote: > In D135128#3902698 , > @stella.stamenova wrote: > >> This caused some failures on the windows mlir buildbot: >> https://lab.llvm.org

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

jansvoboda11 added a comment. In D135128#3902698 , @stella.stamenova wrote: > This caused some failures on the windows mlir buildbot: > https://lab.llvm.org/buildbot/#/builders/13/builds/27829 Thanks for the heads-up. Who would be the best person to lo

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

stella.stamenova added a comment. This caused some failures on the windows mlir buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/27829 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135128/new/ https://reviews.llvm.org/D135128

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

This revision was automatically updated to reflect the committed changes. Closed by commit rG12d8e7c6ade5: [cmake][msvc] Enable standards-conforming preprocessor (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D135128?vs=465112&id=472651#toc Repository: rG LLVM

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. Looks good with the suggestion to split the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135128/new/ https://reviews.llvm.org/D13

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

jansvoboda11 added a comment. In D135128#3839312 , @thieta wrote: > This looks fine to me in principle. But I wonder if we should land the flag > change first separately and make sure that no buildbots break because of it. > Then we can merge the simpli

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

thieta added a comment. This looks fine to me in principle. But I wonder if we should land the flag change first separately and make sure that no buildbots break because of it. Then we can merge the simplification a few days later when we are sure it's stabilized, since something similar happen

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

jansvoboda11 added reviewers: Bigcheese, thieta. jansvoboda11 added a subscriber: thieta. jansvoboda11 added a comment. Adding @thieta as a reviewer for the MSVC flag change, since it's possible due to his D122976 and D130689 .

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

jansvoboda11 updated this revision to Diff 465112. jansvoboda11 added a comment. Squash the original macro with its `_IMPL` counterpart Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135128/new/ https://reviews.llvm.org/D135128 Files: clang/lib/F