[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

void added a comment. In D135107#3840602 , @ronlieb wrote: > hi, seeing our amdgpu buildbot broken with this patch. please look into ? > let me know if you any help on our end. > https://lab.llvm.org/buildbot/#/builders/193/builds/19744 It's been fixed.

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

ronlieb added a comment. hi, seeing our amdgpu buildbot broken with this patch. please look into ? let me know if you any help on our end. https://lab.llvm.org/buildbot/#/builders/193/builds/19744 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135107

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7404b855e528: [clang][NFC] Use enum for -fstrict-flex-arrays (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

serge-sans-paille accepted this revision. serge-sans-paille added a comment. Thanks for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135107/new/ https://reviews.llvm.org/D135107 ___ cfe-com

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

kees accepted this revision. kees added a comment. This revision is now accepted and ready to land. L Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135107/new/ https://reviews.llvm.org/D135107 ___ cfe-co

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

void updated this revision to Diff 465526. void added a comment. Rebase with ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135107/new/ https://reviews.llvm.org/D135107 Files: clang/include/clang/AST/Expr.h clang/include/clang/Basic/LangOp

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

void added inline comments. Comment at: clang/include/clang/Driver/Options.td:1155 + NormalizedValuesScope<"LangOptions::StrictFlexArraysLevelKind">, + NormalizedValues<["Default", "OneZeroOrIncomplete", "ZeroOrIncomplete", "Incomplete"]>, HelpText<"Enable optimizations bas

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

void updated this revision to Diff 465129. void marked an inline comment as done. void added a comment. Use an already available context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135107/new/ https://reviews.llvm.org/D135107 Files: clang/inc

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

void added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:369-376 +/// Any trailing array memeber is a FAM. +Default = 0, +/// Any trailing array member of undefined, 0, or 1 size is a FAM. +OneZeroOrIncomplete = 1, +/// Any trailing arra

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

void updated this revision to Diff 465127. void marked 3 inline comments as done. void added a comment. Fix typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135107/new/ https://reviews.llvm.org/D135107 Files: clang/include/clang/Basic/LangOp

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

steakhal added a comment. The StaticAnalyzer changes seem to be correct. Comment at: clang/include/clang/Basic/LangOptions.h:369-376 +/// Any trailing array memeber is a FAM. +Default = 0, +/// Any trailing array member of undefined, 0, or 1 size is a FAM. +OneZ

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

serge-sans-paille added a comment. Thanks for working on this! A few nits inline Comment at: clang/include/clang/Basic/LangOptions.h:369 + enum class StrictFlexArraysLevelKind { +/// Any trailing array memeber is a FAM. +Default = 0, typo: member ==

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

void created this revision. void added reviewers: efriedma, kees, serge-sans-paille. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.