aaron.ballman closed this revision.
aaron.ballman added a comment.
In http://reviews.llvm.org/D13510#262084, @mgehre wrote:
> The user will see [cppcoreguidelines-c-copy-assignment-signature] in
> warnings, but there is no
> docs/clang-tidy/checks/cppcoreguidelines-c-copy-assignment-signature.r
On Wed, Oct 7, 2015 at 4:18 PM, Samuel Benzaquen wrote:
> sbenza added a comment.
>
> In http://reviews.llvm.org/D13510#261925, @aaron.ballman wrote:
>
>> In http://reviews.llvm.org/D13510#261825, @Eugene.Zelenko wrote:
>>
>> > I think it'll be fine to rename check without leaving traces of misc.
sbenza added a comment.
In http://reviews.llvm.org/D13510#261925, @aaron.ballman wrote:
> In http://reviews.llvm.org/D13510#261825, @Eugene.Zelenko wrote:
>
> > I think it'll be fine to rename check without leaving traces of misc. Same
> > thing happened with modernize-shrink-to-fit.
>
>
> I thi
mgehre added a comment.
The user will see [cppcoreguidelines-c-copy-assignment-signature] in warnings,
but there is no
docs/clang-tidy/checks/cppcoreguidelines-c-copy-assignment-signature.rst.
The user won't know that he needs to look for misc-assign-operator-signature.
Maybe create a link to
aaron.ballman added a comment.
In http://reviews.llvm.org/D13510#261825, @Eugene.Zelenko wrote:
> I think it'll be fine to rename check without leaving traces of misc. Same
> thing happened with modernize-shrink-to-fit.
I think the difference here is that many C++ Core Guideline checks are...
Eugene.Zelenko added a comment.
I think it'll be fine to rename check without leaving traces of misc. Same
thing happened with modernize-shrink-to-fit.
http://reviews.llvm.org/D13510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
aaron.ballman created this revision.
aaron.ballman added reviewers: Eugene.Zelenko, alexfh, mgehre, sbenza.
aaron.ballman added a subscriber: cfe-commits.
Eugene pointed out to me that our existing misc-assign-operator-signature check
was almost perfectly implementing the C++ Core Guideline guida
