This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3a31970ee2af: [C2x] Implement support for nullptr and
nullptr_t (authored by aaron.ballman).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LA
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
Happy with this, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135099/new/
https://reviews.llvm.org/D135099
___
cfe-commit
aaron.ballman added a comment.
Ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135099/new/
https://reviews.llvm.org/D135099
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: clang/include/clang/AST/PrettyPrinter.h:68
SuppressDefaultTemplateArgs(true), Bool(LO.Bool),
-Nullptr(LO.CPlusPlus11), Restrict(LO.C99), Alignof(LO.CPlusPlus11),
+Nullptr(LO.CPlusPlus11), NullptrTypeInNames
aaron.ballman updated this revision to Diff 464973.
aaron.ballman marked 8 inline comments as done.
aaron.ballman added a comment.
Updated based on review feedback.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135099/new/
https://reviews.llvm.org/D135099
Files:
clang/docs/ReleaseNot
shafik added inline comments.
Comment at: clang/lib/Sema/SemaExpr.cpp:8730
+ // result also has that type.
+ if (LHSTy->isNullPtrType() && Context.hasSameType(LHSTy, RHSTy))
+return ResTy;
erichkeane wrote:
> what does this do with the GNU ternary-thing?
shafik added inline comments.
Comment at: clang/lib/Sema/SemaCast.cpp:2999
+ Self.Diag(SrcExpr.get()->getExprLoc(), diag::err_nullptr_cast)
+ << 0 /*nullptr to type*/ << DestType;
+ SrcExpr = ExprError();
Curious why put the comment after? When
erichkeane added inline comments.
Comment at: clang/include/clang/AST/PrettyPrinter.h:68
SuppressDefaultTemplateArgs(true), Bool(LO.Bool),
-Nullptr(LO.CPlusPlus11), Restrict(LO.C99), Alignof(LO.CPlusPlus11),
+Nullptr(LO.CPlusPlus11), NullptrTypeInNamespac
aaron.ballman created this revision.
aaron.ballman added reviewers: jyknight, efriedma, clang-language-wg.
Herald added a project: All.
aaron.ballman requested review of this revision.
Herald added a project: clang.
This introduces support for `nullptr` and `nullptr_t` in C2x mode. The proposal
a
