[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1865-1869 +if ((LangOpts.FastMath || + !LangOpts.FastMath && LangOpts.AllowFPReassoc && LangOpts.AllowRecip && + !LangOpts.FiniteMathOnly && LangOpts.NoSignedZero && + La

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

michele.scandale added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1865-1869 +if ((LangOpts.FastMath || + !LangOpts.FastMath && LangOpts.AllowFPReassoc && LangOpts.AllowRecip && + !LangOpts.FiniteMathOnly && LangOpts.NoSignedZero && +

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1865-1869 +if ((LangOpts.FastMath || + !LangOpts.FastMath && LangOpts.AllowFPReassoc && LangOpts.AllowRecip && + !LangOpts.FiniteMathOnly && LangOpts.NoSignedZero && + La

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

michele.scandale added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1865-1869 +if ((LangOpts.FastMath || + !LangOpts.FastMath && LangOpts.AllowFPReassoc && LangOpts.AllowRecip && + !LangOpts.FiniteMathOnly && LangOpts.NoSignedZero && +

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

kongyi added a comment. In D135097#3859917 , @jrtc27 wrote: > It also will fail if the configured default target triple is one where the > default program address space is non-zero, and maybe other things (do any > targets do pre-IR name mangling for C?

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

jrtc27 added a comment. It also will fail if the configured default target triple is one where the default program address space is non-zero, and maybe other things (do any targets do pre-IR name mangling for C?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

saugustine added a comment. The newly added test func-attr.c fails when run in opt mode. If it is expected to run only at a certain optimization level, it should probably include that level in the test itself. I don't think it seriously blocks anything, but would be good to fix. /usr/local/g

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. zahiraam marked an inline comment as done. Closed by commit rG84a9ec2ff1ee: Remove redundant option -menable-unsafe-fp-math. (authored by zahiraam). Repository: rG L

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/docs/ReleaseNotes.rst:410-412 +- The driver option ``-menable-unsafe-fp-math`` has been removed. Passing it, will +result in a hard err

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam marked an inline comment as done. zahiraam added inline comments. Comment at: clang/docs/ReleaseNotes.rst:410-412 +- The driver option ``-menable-unsafe-fp-math`` has been removed. Passing it, will +result in a hard error. To enable unsafe floating-point optimizations,

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam updated this revision to Diff 467749. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135097/new/ https://reviews.llvm.org/D135097 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Driver/Options.td clang/lib/CodeGen/CGCall.cpp clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:410-412 +- The driver option ``-menable-unsafe-fp-math`` has been removed. Passing it, will +result in a hard error. To enable unsafe floating-point optimizations, the compiler +options ``-funsafe-math-optim

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:410-412 +- The driver option ``-menable-unsafe-fp-math`` has been removed. Passing it, will +result in a hard error. To enable unsafe floating-point optimizations, the compiler +options ``-funsafe-math

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam added inline comments. Comment at: clang/docs/ReleaseNotes.rst:410-412 +- The driver option ``-menable-unsafe-fp-math`` has been removed. Passing it, will +result in a hard error. To enable unsafe floating-point optimizations, the compiler +options ``-funsafe-math-opti

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

probinson added subscribers: wristow, probinson. probinson added a comment. +wristow who has been tracking this kind of stuff for Sony. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135097/new/ https://reviews.llvm.org/D135097 ___ cfe-commits

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

aaron.ballman added a reviewer: clang-vendors. aaron.ballman added a comment. Adding clang-vendors because of the potential for disruption from the changes. Comment at: clang/docs/ReleaseNotes.rst:410-412 +- The driver option ``-menable-unsafe-fp-math`` has been removed. Passin

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam updated this revision to Diff 466474. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135097/new/ https://reviews.llvm.org/D135097 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Driver/Options.td clang/lib/CodeGen/CGCall.cpp clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam added a comment. In D135097#3840706 , @aaron.ballman wrote: > I'm also okay with this direction. I took a look to see if people seemed to > be using this option in their build scripts (maybe we would need a louder > deprecation period), and it

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

aaron.ballman added a comment. I'm also okay with this direction. I took a look to see if people seemed to be using this option in their build scripts (maybe we would need a louder deprecation period), and it seems like most of the uses out there are in forks of Clang. Once I excluded things th

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam updated this revision to Diff 465790. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135097/new/ https://reviews.llvm.org/D135097 Files: clang/include/clang/Driver/Options.td clang/lib/CodeGen/CGCall.cpp clang/lib/Driver/ToolChains/Clang.cpp clang/test/CodeGen/fp-options-

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

MaskRay added a comment. Thanks for noticing the issue. There are some formatting issues in the description:) And a typo in the table cell `initeMathOnly` -menable-unsafe-fp-math looks like a CC1 for a long time, probably from 2012. In 2020 D82574 accidentally

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam updated this revision to Diff 465768. zahiraam added reviewers: andrew.w.kaylor, aaron.ballman, rjmccall, efriedma, fhahn, dexonsmith. zahiraam changed the visibility from "Custom Policy" to "Public (No Login Required)". Herald added a subscriber: MaskRay. CHANGES SINCE LAST ACTION ht