[PATCH] D135011: Add sin and cos llvm intrinsics

2022-10-03 Thread Florian Hahn via Phabricator via cfe-commits
fhahn added a comment. Could you update the title to make it clear this adds new Clang builtins, not intrinsics (they are lowered to LLVM intrinsics). The behavior of the new builtins should be specified in `LanguageExtensions.rst` (https://clang.llvm.org/docs/LanguageExtensions.html#vector-bui

[PATCH] D135011: Add sin and cos llvm intrinsics

2022-10-03 Thread Joshua Batista via Phabricator via cfe-commits
bob80905 updated this revision to Diff 464730. bob80905 added a comment. run git clang-format on changes rather than whole document Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 Files: clang/include/c

[PATCH] D135011: Add sin and cos llvm intrinsics

2022-09-30 Thread Joshua Batista via Phabricator via cfe-commits
bob80905 updated this revision to Diff 464472. bob80905 added a comment. - make format consistent, update test copy mistake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 Files: clang/include/clang/Bas

[PATCH] D135011: Add sin and cos llvm intrinsics

2022-09-30 Thread Joshua Batista via Phabricator via cfe-commits
bob80905 updated this revision to Diff 464471. bob80905 added a comment. rever format commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 Files: clang/include/clang/Basic/Builtins.def clang/lib/Cod

[PATCH] D135011: Add sin and cos llvm intrinsics

2022-09-30 Thread Joshua Batista via Phabricator via cfe-commits
bob80905 created this revision. bob80905 added reviewers: beanz, python3kgae. Herald added a project: All. bob80905 requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead. Herald added a project: clang. add codegen for llvm cos and sin intrinsics Repository: rG