[PATCH] D135011: Add sin and cos llvm builtins

python3kgae added a comment. In D135011#3831949 , @rjmccall wrote: > The titled of this patch should be something like "Add > __builtin_elementwise_sin and __builtin_elementwise_cos". > > Can you explain why this uses a new builtin name instead of overlo

[PATCH] D135011: Add sin and cos llvm builtins

rjmccall added a comment. The titled of this patch should be something like "Add __builtin_elementwise_sin and __builtin_elementwise_cos". Can you explain why this uses a new builtin name instead of overloading the existing builtins to work on vectors? I can imagine reasons why, but I think i

[PATCH] D135011: Add sin and cos llvm builtins

craig.topper added a comment. Does these support scalable vector types from ARM SVE or RISC-V? I can't remember what the rest of the __builtin_elementwise do. I ask because the backends will probably crash for them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D135011: Add sin and cos llvm builtins

bob80905 updated this revision to Diff 464744. bob80905 edited the summary of this revision. bob80905 added a comment. - add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 Files: clang/doc

[PATCH] D135011: Add sin and cos llvm builtins

bob80905 updated this revision to Diff 464739. bob80905 added a comment. - add docs, add new line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 Files: clang/docs/LanguageExtensions.rst clang/include

[PATCH] D135011: Add sin and cos llvm builtins

erichkeane added a comment. Please clarify the commit message (review description) to better explain what it is you're doing here, the purpose/etc as well as the documentation requested by @fhahn This also needs release notes. Comment at: clang/test/SemaCXX/builtins-elementw