[PATCH] D134898: [Clang] define __cpp_named_character_escapes

2022-09-30 Thread Roy Jacobson via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbd1bb8cd4254: [Clang] define __cpp_named_character_escapes (authored by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D134898: [Clang] define __cpp_named_character_escapes

2022-09-30 Thread Roy Jacobson via Phabricator via cfe-commits
royjacobson added a comment. In D134898#3825255 , @cor3ntin wrote: > Thanks for catching that, I missed there was a feature test macro for it. > It doesn't really make sense for it to be a feature test macro (given WG21's > current policies) so I'll make

[PATCH] D134898: [Clang] define __cpp_named_character_escapes

2022-09-30 Thread Roy Jacobson via Phabricator via cfe-commits
royjacobson updated this revision to Diff 464174. royjacobson added a comment. Remove literal suffix in accordance with the rest of the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134898/new/ https://reviews.llvm.org/D134898 Files: clang/

[PATCH] D134898: [Clang] define __cpp_named_character_escapes

2022-09-29 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. Thanks for catching that, I missed there was a feature test macro for it. It doesn't really make sense for it to be a feature test macro (given WG21's current policies) so I'll make raise an issue about that but I'm happy to approve the change in the meantime Reposito

[PATCH] D134898: [Clang] define __cpp_named_character_escapes

2022-09-29 Thread Roy Jacobson via Phabricator via cfe-commits
royjacobson updated this revision to Diff 464007. royjacobson added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134898/new/ https://reviews.llvm.org/D134898 Files: clang/lib/Frontend/InitPreprocessor.cpp clang/test/Lexer/cx

[PATCH] D134898: [Clang] define __cpp_named_character_escapes

2022-09-29 Thread Roy Jacobson via Phabricator via cfe-commits
royjacobson created this revision. royjacobson added a reviewer: cor3ntin. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Define the feature test macro for named character escapes. I assume this was