[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. rymiel marked an inline comment as done. Closed by commit rGdce5bb9a6f89: [clang-format] Correctly annotate UDLs as OverloadedOperator (authored by rymiel). Repository

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

owenpan accepted this revision. owenpan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134853/new/ https://reviews.llvm.org/D134853 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

rymiel marked 2 inline comments as done. rymiel added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2126 return false; FormatToken *LeftOfParens = Tok.MatchingParen->getPreviousNonComment(); owenpan wrote: > Perhaps add: > ``` >

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

rymiel updated this revision to Diff 468473. rymiel marked 4 inline comments as done. rymiel added a comment. Do not annotate the trailing identifier of an UDL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134853/new/ https://reviews.llvm.org/D1348

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2126 return false; FormatToken *LeftOfParens = Tok.MatchingParen->getPreviousNonComment(); Perhaps add: ``` if (Tok.MatchingParen->is(TT_OverloadedOperatorLParen))

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

rymiel added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:413 + EXPECT_TOKEN(Tokens[3], tok::string_literal, TT_OverloadedOperator); + EXPECT_TOKEN(Tokens[4], tok::identifier, TT_OverloadedOperator); + EXPECT_TOKEN(Tokens[5], tok::l_paren, TT_Over

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1186-1199 +tok::amp, tok::ampamp)) { CurrentToken->Previous->setType(TT_OverloadedOperator); } +// User defined literal without a

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

rymiel updated this revision to Diff 467677. rymiel added a comment. Full stops in comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134853/new/ https://reviews.llvm.org/D134853 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/F

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:1189-1194 +// User defined literal without a space +if (CurrentToken->Previous->is

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

rymiel updated this revision to Diff 466862. rymiel marked an inline comment as done. rymiel added a comment. Handle UDLs with and without spaces Thank you @owenpan, I was not actually aware UDLs without spaces were valid. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

owenpan added a comment. In D134853#3829433 , @rymiel wrote: > So, after some investigation, it turns out the clang lexer only combines an > underscore-less UDL to a single `string_literal` token if it's a valid > standard library UDL (in the given stan

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

rymiel added a comment. > The operator `""` and the identifier that follows should be two separate > tokens regardless if the identifier starts with an underscore. So, after some investigation, it turns out the clang lexer only combines an underscore-less UDL to a single `string_literal` token

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

owenpan added a comment. In D134853#3822842 , @rymiel wrote: > Unless any reviewers have any other opinions, I would leave fixing those out > of this patch and leave the tests "incomplete" for now? +1. > Also, UDLs that don't start with an underscore a

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

HazardyKnusperkeks added a comment. Looks good. You could add a FIXME before the commented out tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134853/new/ https://reviews.llvm.org/D134853 ___ cfe-co

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay, curdeius. Herald added a project: All. rymiel updated this revision to Diff 463768. rymiel edited the summary of this revision. rymiel added a comment. rymiel updated this revision to Diff 464145. rym