This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG542123465f9e: [clang][Interp] Implement bitwise not
operations (authored by tbaeder).
Changed prior to commit:
https://reviews.llvm.org/D134804?vs
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134804/new/
https://reviews.llvm.org/D134804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
tbaeder updated this revision to Diff 464155.
tbaeder marked 4 inline comments as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134804/new/
https://reviews.llvm.org/D134804
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/Integral.h
clang/lib/AST/Interp/In
aaron.ballman added a comment.
LGTM aside from a question about naming.
Comment at: clang/lib/AST/Interp/Integral.h:228-231
+ static bool Not(Integral A, Integral *R) {
+*R = Integral(~A.V);
+return false;
+ }
Can we name this one `complement` instead
tbaeder updated this revision to Diff 463791.
tbaeder marked an inline comment as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134804/new/
https://reviews.llvm.org/D134804
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/Integral.h
clang/lib/AST/Interp/In
shafik accepted this revision.
shafik added a comment.
This revision is now accepted and ready to land.
Otherwise LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134804/new/
https://reviews.llvm.org/D134804
___
cfe-commits mailing list
cfe
shafik added inline comments.
Comment at: clang/test/AST/Interp/literals.cpp:72
+static_assert(~-1 == 0, "");
+static_assert(~255 == -256, "");
+
Some more tests covering `~INT_MIN == INT_MAX` and vice versa and unscoped enum
case as well e.g.
```
enum E {};
E
tbaeder updated this revision to Diff 463515.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134804/new/
https://reviews.llvm.org/D134804
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/Integral.h
clang/lib/AST/Interp/Interp.h
clang/lib/AST/Interp/Opcodes.td
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://revi
