[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

eopXD added a comment. Hi @fhahn, After a second thought, I think posting a clear RFC [0] to the community that defines the problem and goal this patch tries to achieve so the community is notified of such change is a better approach than directly updating this patch. Please consider to drop b

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

eopXD added a comment. @fhahn Thank you very much for the review, backward compatibility is a good point. I will update the revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134745/new/ https://reviews.llvm.org/D134745 _

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

fhahn added a comment. > Adding this metadata allows {loop.vectorize.enable, false} to be used without > disabling the whole pass. Could you please describe the behavior in more detail here? The new metadata should also be documented in `LangRef`, the new pragma in https://clang.llvm.org/docs/

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

eopXD added a comment. Gentle ping, thank you ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134745/new/ https://reviews.llvm.org/D134745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

eopXD updated this revision to Diff 463299. eopXD added a comment. Fix grammar error in comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134745/new/ https://reviews.llvm.org/D134745 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeG

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

eopXD marked an inline comment as done. eopXD added a comment. After this patch, we can remove setVectorizeWidth(1) and setInterleaveCount(1) when vectorize(disable) and interleave(disable) is specified. For now it is not removed to keep the patch limited and simple enough. Repository: rG LL

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

eopXD updated this revision to Diff 463261. eopXD added a comment. Update comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134745/new/ https://reviews.llvm.org/D134745 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CGLoopInfo.

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

mcberg2021 added inline comments. Comment at: clang/lib/CodeGen/CGLoopInfo.cpp:673 +setInterleaveEnable(false); setInterleaveCount(1); break; Can you update the comments on lines: 665 and 671 as they both need update. Repository: rG

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

eopXD added a comment. Please feel free to add appropriate reviewer to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134745/new/ https://reviews.llvm.org/D134745 ___ cfe-commits mailing list

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

eopXD created this revision. eopXD added reviewers: sdesmalen, paulwalker-arm, fhahn, reames, hfinkel. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabua