[PATCH] D134673: [Driver][PS4] pass -fcrash-diagnostics-dir to LTO

2022-09-27 Thread Yuanfang Chen via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG55cd5bc50964: [Driver][PS4] pass -fcrash-diagnostics-dir to LTO (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134673/new/ https://revie

[PATCH] D134673: [Driver][PS4] pass -fcrash-diagnostics-dir to LTO

2022-09-27 Thread Paul Robinson via Phabricator via cfe-commits
probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134673/new/ https://reviews.llvm.org/D134673 _

[PATCH] D134673: [Driver][PS4] pass -fcrash-diagnostics-dir to LTO

2022-09-26 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added a comment. In D134673#3816166 , @probinson wrote: > I'm guessing the non-PS4 targets would also want this, so a similar change is > needed in tools::addLTOOptions. This can be a separate patch if you wish. That's right. It was submitted htt

[PATCH] D134673: [Driver][PS4] pass -fcrash-diagnostics-dir to LTO

2022-09-26 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. I'm guessing the non-PS4 targets would also want this, so a similar change is needed in tools::addLTOOptions. This can be a separate patch if you wish. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134673/new/ https://r

[PATCH] D134673: [Driver][PS4] pass -fcrash-diagnostics-dir to LTO

2022-09-26 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen created this revision. ychen added a reviewer: probinson. Herald added a subscriber: inglorion. Herald added a project: All. ychen requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Also refactor the existing code a little bit.