[PATCH] D134657: [Driver] pass -fcrash-diagnostics-dir to LTO

thakis added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134657/new/ https://reviews.llvm.org/D134657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D134657: [Driver] pass -fcrash-diagnostics-dir to LTO

ychen added a comment. In D134657#3819435 , @thakis wrote: > This breaks `Driver/crash-diagnostics-dir-2.c` on my mac: > > FAIL: Clang :: Driver/crash-diagnostics-dir-2.c (7510 of 15804) > TEST 'Clang :: Driver/crash-diagnostics-d

[PATCH] D134657: [Driver] pass -fcrash-diagnostics-dir to LTO

thakis added a comment. This breaks `Driver/crash-diagnostics-dir-2.c` on my mac: FAIL: Clang :: Driver/crash-diagnostics-dir-2.c (7510 of 15804) TEST 'Clang :: Driver/crash-diagnostics-dir-2.c' FAILED Script: -- : 'RUN: at line 3'; /Users/th

[PATCH] D134657: [Driver] pass -fcrash-diagnostics-dir to LTO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5839fb6d25b4: [Driver] pass -fcrash-diagnostics-dir to LTO (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D134657: [Driver] pass -fcrash-diagnostics-dir to LTO

ychen updated this revision to Diff 462968. ychen added a comment. - use getLastArg - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134657/new/ https://reviews.llvm.org/D134657 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/tes

[PATCH] D134657: [Driver] pass -fcrash-diagnostics-dir to LTO

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:635 + // Setup crash diagnostics dir. + if (Args.hasArg(options::OPT_fcrash_diagnostics_dir)) { +StringRef

[PATCH] D134657: [Driver] pass -fcrash-diagnostics-dir to LTO

ychen created this revision. ychen added reviewers: MaskRay, probinson. Herald added subscribers: StephenFan, inglorion. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. So the behavior is consistent with n