This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1fa115b56979: [clang-format] Correctly indent closing brace
of compound requires (authored by rymiel).
Repository:
rG LLVM Github Monorepo
CHANGE
MyDeveloperDay accepted this revision.
MyDeveloperDay added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134626/new/
https://reviews.llvm.org/D134626
___
rymiel added a comment.
I built 2 versions of clang-format, before and after this patch, and made 2
separate clones of all of LLVM+clang and ran them through either, removing all
`.clang-format`s, then ran a recursive diff.
I found 1 difference, in a test case at
`clang/test/CodeGen/constraine
MyDeveloperDay added a comment.
Hmm…it’s nice when it’s this simple, but I get an uneasy feeling about the
knock on effects. I’d say go for it but perhaps we could run it over a larger
code base to see the implications
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://
rymiel added a comment.
Note: I don't have the historical insight to know why the code order was as it
was. I simply tried yoinking the place where the level was being set to occur
earlier, and it surprisingly seemed to work, and also seemed to not break any
other tests; I hope it doesn't break
rymiel created this revision.
rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay, curdeius.
Herald added a project: All.
rymiel requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
When a compound requirement is too long to fit
