[PATCH] D134549: [clang] Add fix-it note to defaulted-function-deleted warning

This revision was automatically updated to reflect the committed changes. Closed by commit rG1376c73927dc: [clang] Add fix-it note to defaulted-function-deleted warning (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134549/new/

[PATCH] D134549: [clang] Add fix-it note to defaulted-function-deleted warning

njames93 updated this revision to Diff 465045. njames93 added a comment. Rebase to trunk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134549/new/ https://reviews.llvm.org/D134549 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/Decl

[PATCH] D134549: [clang] Add fix-it note to defaulted-function-deleted warning

njames93 updated this revision to Diff 465042. njames93 added a comment. Address @martong's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134549/new/ https://reviews.llvm.org/D134549 Files: clang/docs/ReleaseNotes.rst clang/include/cl

[PATCH] D134549: [clang] Add fix-it note to defaulted-function-deleted warning

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though please address the concern by @martong before landing. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134549

[PATCH] D134549: [clang] Add fix-it note to defaulted-function-deleted warning

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3707 ToFunction->setRangeEnd(ToEndLoc); + ToFunction->setDefaultLoc(D->getDefaultLoc()); This should be imported very similarly to `EndLoc`. Repository: rG LLVM Github Monorepo CH

[PATCH] D134549: [clang] Add fix-it note to defaulted-function-deleted warning

njames93 updated this revision to Diff 462685. njames93 added a comment. Rebase fixing merge conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134549/new/ https://reviews.llvm.org/D134549 Files: clang/docs/ReleaseNotes.rst clang/include

[PATCH] D134549: [clang] Add fix-it note to defaulted-function-deleted warning

njames93 updated this revision to Diff 462684. njames93 marked an inline comment as done. njames93 added a comment. Add release notes and fix issue in ASTWriterDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134549/new/ https://reviews.llvm.org

[PATCH] D134549: [clang] Add fix-it note to defaulted-function-deleted warning

njames93 added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:2291 Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::VBR, 6)); // LocEnd + Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::VBR, 3)); // Default/DeleteLoc Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp:

[PATCH] D134549: [clang] Add fix-it note to defaulted-function-deleted warning

aaron.ballman added a comment. Thank you for this, I think it's a good idea! Can you also add a release note for the changes? This mostly LG to me but I did spot one thing I was curious about. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:2291 Abv->Add(BitCodeAbbre

[PATCH] D134549: [clang] Add fix-it note to defaulted-function-deleted warning

njames93 created this revision. njames93 added a reviewer: aaron.ballman. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds a fix