This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG844b84af20c7: [clang-offload-bundler] extracting compatible
bundle entry (authored by yaxunl).
Herald added a project: clang.
Repository:
rG LLVM
yaxunl updated this revision to Diff 465265.
yaxunl marked an inline comment as done.
yaxunl added a comment.
check bundle entry ID compatibility when bundling
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134546/new/
https://reviews.llvm.org/D134546
Files:
clang/include/clang/Basic/
yaxunl marked 3 inline comments as done.
yaxunl added inline comments.
Comment at: clang/lib/Driver/OffloadBundler.cpp:1008
+auto Output = Worklist.begin();
+for (auto E = Worklist.end(); Output != E; Output++) {
+ if (isCodeObjectCompatible(
tra wro
tra added inline comments.
Comment at: clang/lib/Driver/OffloadBundler.cpp:1008
+auto Output = Worklist.begin();
+for (auto E = Worklist.end(); Output != E; Output++) {
+ if (isCodeObjectCompatible(
saiislam wrote:
> tra wrote:
> > The patch descript
saiislam added a comment.
The patch looks fine to me.
Please wait for @tra 's final review.
On a different note, can this compatibility testing logic be moved to a llvm
library instead of clang's?
I want to use it in OpenMP's AMDGPU plugin, which now links llvm libraries by
default.
tra added inline comments.
Comment at: clang/lib/Driver/OffloadBundler.cpp:1008
+auto Output = Worklist.begin();
+for (auto E = Worklist.end(); Output != E; Output++) {
+ if (isCodeObjectCompatible(
The patch description implies that there are at lea
yaxunl created this revision.
yaxunl added reviewers: tra, saiislam, lamb-j.
Herald added a project: All.
yaxunl requested review of this revision.
Herald added subscribers: sstefan1, MaskRay.
Herald added a reviewer: jdoerfert.
In HIP a library is usually compiled with default target ID e.g. gfx9
