Apologies for reviving a long dead thread, but I think we need to re-evalute
this change.
With CMake 3.4 I’m seeing some nasty error spew on our internal builds. The
spew can be reproduced with the following CMake invocation:
> cmake -G Ninja -DLLVM_ENABLE_PIC=Off -DLLVM_INSTALL_TOOLCHAIN_ONLY=
chapuni closed this revision.
chapuni added a comment.
Applied in r249935, thanks!
http://reviews.llvm.org/D13453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added a comment.
Btw, I don't have commit access, so if you are happy with this change, could
you commit it for me?
http://reviews.llvm.org/D13453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
hintonda updated this revision to Diff 36916.
hintonda added a comment.
Add support for cmake version 3, i.e., 3.0.0...
http://reviews.llvm.org/D13453
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMakeLists.txt
+++ CMakeL
chapuni accepted this revision.
This revision is now accepted and ready to land.
Comment at: CMakeLists.txt:553
@@ -552,3 +552,3 @@
-if (CLANG_BUILT_STANDALONE)
+if (CLANG_BUILT_STANDALONE OR CMAKE_VERSION VERSION_GREATER 3)
# Generate a list of CMake library targets so that
hintonda updated this revision to Diff 36889.
hintonda added a comment.
- add back check for standalone and add cmake version
http://reviews.llvm.org/D13453
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMakeLists.txt
+++
rnk added a comment.
I added this conditional check in r221415, with this message:
cmake: Only export targets in the standalone build
Trying to fix bots that didn't like the fact that I exported targets
that depended on LLVM without exporting targets from LLVM.
I assume this has already
hintonda added a comment.
Installed cmake 2.8.12 and was able to reproduce error.
I'll look into it, but I'm tempted to only support newer versions of cmake, and
let older versions maintain current behavior.
http://reviews.llvm.org/D13453
___
cfe-
chapuni requested changes to this revision.
chapuni added a comment.
This revision now requires changes to proceed.
This change requires cmake-3.
With CMake-2.8.12.2,
CMake Error at
/home/tnakamura/fio/ninja/llvm-project/clang/CMakeLists.txt:560 (export):
export called with target "clangB
chapuni added a comment.
I am testing this with cmake-2.8.12. I remember some issues would be there.
http://reviews.llvm.org/D13453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D13453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
jordan_rose resigned from this revision.
jordan_rose edited reviewers, added: beanz; removed: jordan_rose.
jordan_rose added a comment.
I just get things to build with CMake, and I'm not involved with Clang so much
these days. This is more about controlling what gets installed, which should be
c
chapuni added a reviewer: jordan_rose.
chapuni added a comment.
LGTM, but I haven't tested. I'll wait for 3rd opinion for several hours. :)
I thought it may be moved to an arbitrary subdirectory.
http://reviews.llvm.org/D13453
___
cfe-commits maili
hintonda created this revision.
hintonda added a reviewer: chapuni.
hintonda added a subscriber: cfe-commits.
Always generate and install cmake config files.
Currently, cmake config files are only generated and installed when
CLANG_BUILD_STANDALONE set, which means config file will not be genera
14 matches
Mail list logo
